Add script to tune parameters #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasfaingnaert
force-pushed
the
tf/parameter-tuning
branch
from
6afd275
to
c154582
Compare
|
RTX6000 Ada: H100: No plot, as it failed during |
thomasfaingnaert
force-pushed
the
tf/parameter-tuning
branch
28 times, most recently
from
30e6e26
to
a50cfe6
Compare
maleadt
reviewed
Dec 6, 2023
Comment on lines
+68
to
+73
| # Sudo keep-alive | ||
| while true; do | ||
| sleep 300 | ||
| sudo -n true | ||
| kill -0 "$$" || exit | ||
| done &> /dev/null & |
There was a problem hiding this comment.
Ha, cute! Maybe could be more reliable (e.g. when sudo is configured always to prompt again) to fork off a privileged process that waits for the parent though.
Instead of the uncertainty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple script to perform an exhaustive search on the parameter space, based on #154.
For the RTX 4070, these are the results:
plot.pdf
I've been gradually generalising the kernel by fixing any miscompilations / incorrect results that come up, but we still only explore a relatively small part of the design space (around 3.2 / (100 - 85) = 21.3% of the configurations that ought to work). At some point I'll have to look into the incorrect results and error-throwing configurations:
@maleadt Could you have a look at this and run it on more recent hardware as well?
Some notes:
Octavianto generate the groundtruth on the CPU is pretty much a requirement if you don't want to wait around forever. Probably better to generate the groundtruth on the GPU instead.@cuprintfresolves it. I've added an assert for now to mask the issue so we can test that configuration. (Under the assumption that that will not influence the run time too much...)